Remove extraneous space from figure shortcode #8404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndim
suggested changes
Apr 10, 2021
There was a problem hiding this comment.
A few lines below the <!-- Closing img tag --> comment, the figure shortcode defines another <a> anchor element, this time inside a <figcaption> element.
Interestingly, the definition of this element uses {{- end -}} after closing the opening <a> tag, which AFAICT removes the same type of whitespace which is an issue in the first <a> element defined by the figure shortcode.
So AFAICT, if you copy the solution from line 22 to line 4, that should fix the issue.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8401