Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockquote alert render hook removes ending p letter in alerttitle #13119

Closed
McShelby opened this issue Dec 9, 2024 · 2 comments · Fixed by #13122
Closed

blockquote alert render hook removes ending p letter in alerttitle #13119

McShelby opened this issue Dec 9, 2024 · 2 comments · Fixed by #13122

Comments

@McShelby
Copy link

McShelby commented Dec 9, 2024

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.139.3-2f6864387cd31b975914e8373d4bf38bddbd47bc windows/amd64 BuildDate=2024-11-29T15:36:56Z VendorInfo=gohugoio

Does this issue reproduce with the latest release?

Yes

Description

Using the default blockquote render hook implementation from https://gohugo.io/render-hooks/blockquotes/#example causes a final p letter in the alerttitle to be removed. This is not an issue of the render hook.

> [!note] Heads up
> The letter "p" does not display properly in the title.

See home page of /~https://github.com/McShelby/hugo-testing/tree/hugo-github-issue-13119

@McShelby McShelby changed the title blockquote alert removes ending p letter in alerttitle blockquote alert render hook removes ending p letter in alerttitle Dec 9, 2024
@McShelby
Copy link
Author

McShelby commented Dec 9, 2024

The reason lies in gohugoio/hugo/markup/goldmark/blockquotes/blockquotes.go:168 where strings.TrimRight needs to be replaced with strings.TrimSuffix.

Copy link

github-actions bot commented Jan 1, 2025

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants