converter: fix image platform matcher #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imeoer
force-pushed
the
fix-platform-matcher
branch
2 times, most recently
from
9071ac1 to
b5fd46f
Compare
imeoer
changed the title
imeoer
changed the title
imeoer
force-pushed
the
fix-platform-matcher
branch
from
b5fd46f to
6bd5c35
Compare
imeoer
changed the title
liubogithub
reviewed
Mar 14, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return nydusUtils.ExcludeNydusPlatformComparer{MatchComparer: platformMC}, nil |
There was a problem hiding this comment.
Seems that no one is using nydusUtils.ExcludeNydusPlatformComparer anymore, are we good to remove it entirely?
liubogithub
approved these changes
Mar 14, 2023
We should only handle specific platform for pulling and pushing by `platforms.MatchComparer`, otherwise acceld will pull/push the layer data of all platforms for an image. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
To avoid importing a large number of redundant dependencies, we ported harbor structure definitions. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
To bring some fixups for nydus-image binary. Signed-off-by: Yan Song <imeoer@linux.alibaba.com>
imeoer
force-pushed
the
fix-platform-matcher
branch
from
b8be097 to
bf78872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converter: fix platform matcher
We should only handle specific platform for pulling and
pushing by
platforms.MatchComparer, otherwise acceldwill pull/push the layer data of all platforms for an image.
deps: remove harbor structure definition
To avoid importing a large number of redundant dependencies,
we ported harbor structure definitions.
action: bump nydus v2.1.5
To bring some fixups for nydus-image binary.