Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arrays of StringName, NodePath and RID in mono #53576

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Support arrays of StringName, NodePath and RID in mono #53576

merged 1 commit into from
Oct 15, 2021

Conversation

raulsntos
Copy link
Member

@raulsntos raulsntos commented Oct 8, 2021 •
edited
Loading

Fixes #53362
Fixes #50661
Fixes #47621

Since these types don't inherit from Godot.Object they weren't supported in mono_object_to_variant which is used by tool exports.

@raulsntos raulsntos requested a review from a team as a code owner October 8, 2021 16:54
This was referenced Oct 8, 2021
Merged
Closed
@Calinou Calinou added this to the 4.0 milestone Oct 8, 2021
@Calinou Calinou added bug and removed enhancement labels Oct 8, 2021
@raulsntos raulsntos mentioned this pull request Oct 8, 2021
Closed
neikeq
neikeq suggested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@neikeq neikeq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but this needs to be handled in GDMonoField::set_value_from_variant too:

godot/modules/mono/mono_gd/gd_mono_field.cpp

Line 48 in 3f88896

void GDMonoField::set_value_from_variant(MonoObject *p_object, const Variant &p_value) {

neikeq
neikeq approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@neikeq neikeq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind. Looks like the array implementation for fields was moved to GDMonoMarshal::variant_to_mono_array which this PR correctly implements.

@akien-mga akien-mga merged commit 4a0a91f into godotengine:master Oct 15, 2021
@akien-mga
Copy link
Member

Thanks!

@raulsntos raulsntos deleted the fix-mono-to-variant-array branch October 15, 2021 15:44
@pranshuthegamer
Copy link

how do i use NodePath arrays in c# then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neikeq neikeq neikeq approved these changes

Assignees
No one assigned
Labels
bug topic:dotnet
Projects
None yet
Milestone
4.0
5 participants
@raulsntos @akien-mga @pranshuthegamer @neikeq @Calinou