Node create dialog filtering optimization #33387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnationsdev
approved these changes
Nov 6, 2019
editor/create_dialog.cpp
Outdated
| @@ -321,6 +325,9 @@ void CreateDialog::_update_search() { | |||
|
|
|||
| TreeItem *to_select = search_box->get_text() == base_type ? root : NULL; | |||
|
|
|||
| // Keep references to loaded scripts to avoid loading and parsing them several times | |||
| HashMap<String, RES> loaded_scripts; | |||
There was a problem hiding this comment.
While not necessary @pouleyKetchoupp, would it be possible to have this be a variable in the class itself rather than a local variable? And then just clear it whenever the "config" method, or maybe the "popup" method, is called? That way it doesn't have to rebuild this map on every key press, but rather keeps the scripts loaded the entire time the user has it open.
There was a problem hiding this comment.
Yes, let me look into that.
Avoid loading the same scripts again and parse them when updating the node type tree.
pouleyKetchoupp
force-pushed
the
faster-create-dialog-filter
branch
from
ded32f4 to
fb9ff92
Compare
|
Thanks @willnationsdev for your feedback. |
|
Great! I think things here are good to go @akien-mga. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid loading the same scripts several times to parse them in order to update the node type tree.
Improvement for #27333
(~2 times faster to update tree)