Fix First Ctrl+R and Ctrl+F not showing long name variables correctly #28583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@akien-mga / @YeldhamDev: I would like to request a review of my pull request. Could you please review my changes or assign a reviewer to my pull request? |
|
@akien-mga, @YeldhamDev : Any update for this pull request? |
akien-mga
reviewed
May 15, 2019
| if (expand_to_text_length) { | ||
| window_pos = 0; //force scroll back since it's expanding to text length | ||
| } | ||
| window_pos = 0; //force scroll back since it's expanding to text length |
There was a problem hiding this comment.
The comment is no longer accurate.
There was a problem hiding this comment.
Yes you are right. Could you please remove it from master since it is already merged there?
@akien-mga , @YeldhamDev Thank you for reviewing my pull request.
There was a problem hiding this comment.
I've removed it in this pull: #28913.
And you're very welcome!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26982