Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger's inspector doesn't clear it values on every debug action #28407

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

erammos
Copy link
Contributor

@erammos erammos commented Apr 24, 2019

Hello, my first PR :)
This fix is related to #26993
I am waiting for your feedback!

@Geequlim
Copy link
Contributor

Geequlim commented Apr 25, 2019

Is it still safe to modify remote values in the inspector after the debugger disconnected (not stopped as normal) ?

@akien-mga akien-mga added this to the 3.2 milestone Apr 25, 2019
@erammos
Copy link
Contributor Author

erammos commented Apr 25, 2019

Is it still safe to modify remote values in the inspector after the debugger disconnected (not stopped as normal) ?

I am not sure if I understood the question. I don't see any related issue with remote values. if i force disconnection (e.g disconnect USB cable of android device) , the debugger's inspector (bottom right panel) will close instantly.

@akien-mga akien-mga merged commit 8f337b6 into godotengine:master Apr 29, 2019
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants