Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Lightmapper denoising library includes deep neural network library that does not support 32 bits. #38759

Closed
Tracked by #39196
madmiraal opened this issue May 15, 2020 · 1 comment · Fixed by #39342

Comments

@madmiraal
Copy link
Contributor

Godot version: master (00949f0)

OS/device including version: 32 bit platforms.

Issue description: The new lightmapper #38386 introduced a new denoising library: oidn that includes a Deep Neural Network library: oneDNN that only supports 64 bits:

oneDNN supports platforms based on the following architectures:

  • Intel 64 or AMD64,
  • Arm 64-bit Architecture (AArch64).

Steps to reproduce: Try compile master (with #38757 to avoid an earlier compilation error) using: scons -j8 platform=windows tools=yes bits=32 causes an assertion error:

static_assert(sizeof(void*) == 8, "Intel(R) MKL-DNN supports 64 bit only");

Minimal reproduction project: N/A

Furthermore it includes a warning about limited support on Arm processors.

WARNING
Arm 64-bit Architecture (AArch64) support is experimental with limited testing validation.

@madmiraal madmiraal changed the title New Lightmapper denoising library includes deep neural network library that does not supported 32 bits. New Lightmapper denoising library includes deep neural network library that does not support 32 bits. May 15, 2020
@akien-mga
Copy link
Member

Its build should be restricted to tools=yes and desktop platforms, it won't be used in templates and even if we enable Android editor builds, it doesn't make sense to bake lightmaps on a mobile device.

I guess we can also disable it on 32-bit desktop builds.

@akien-mga akien-mga added this to the 4.0 milestone May 15, 2020
@akien-mga akien-mga self-assigned this Jun 6, 2020
akien-mga added a commit to akien-mga/godot that referenced this issue Jun 6, 2020
One of OIDN's dependencies only supports x86_64 and aarch64.
For now we also exclude potential future Android tools builds,
but this could be re-evaluated in the future.

Fixes godotengine#38759.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants