-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI-1488: Upgrade draupnir to use pg-14 #446
Conversation
I've been enjoying these PRs, thanks for the entertainment! |
@lawrencejones feel free to join our next treasure hunt, should be an in-person one |
f487610
to
d58b071
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, just one thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM We did something similar on frontier and payments-svc. Knowing that vagrant files and docker files are almost a copy of each other i think we can merge this!
55b3d55
to
d4eca62
Compare
It's a squashed commit that has ended up being reverted, as things never seemed to work fully. Has been kept in for the time being as some of the subsequent commits involved changes to files modified by these commits. Below is a view on the changes introduced by these commits: New vargantfile for M1 This might work, might not. Who knows :) more stuff trying random things maybe it'll work - looks like we were using go 1.10, but go.mod requires 1.14, so let's use that and see... Updating config to use a newer go and attempt to install btrfs Final attempt at using qemu as a vagrant provider Currently failing to mount the btfrs volume Undo changes to vagrant file
Debugging failing tests in the running container. Installing postgres 14 WIP getting integration tests passing Current thinking is, the db.tar file was created from pg11
Update all uses of postgres to use postgres 14 Update go to 1.17 and ruby to 2.7.2 Update go pq dependency Remove mentions of dep from readme
Remove comment for provision.sh start lines Undo line break in create-instance
This fixes all integration tests
Update integration test task to build the dockerfile locally, so we always use the latest, local changes
Trying to use a more modern openssl No longer install ruby manually install it in docker directly Update ruby to 3.0.2 Update ruby version and readme Update draupnir version and changelog Update go and ruby images One to use the maintainted circleci image for Golang, and the ruby one to match the necessary ruby version
03597cf
to
9ba5e65
Compare
Big fan of draupnir. Would love to see this merged! 👀 |
To match the rest of the containers
From SCSI to SATA
Remove unnecessary ruby from the dockerfile
provision.sh To use cat again
Update certificate to use -extfile instead of -addext Use the right volume for the SATA controller
Use `go install`, as per newer golang guidance, and pin a version so that we don't end up with nasty surprises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - works locally so happy to get this merged in
Actual footage of this work
This started out as a bit of a red herring, trying to get the vagrant file working. Ended up not doing so, and focused on getting the integration tests working locally.
A quick rundown of what's changed:
provision.sh
and all the draupnir scriptsdeb
from the readme, anddeb
files, as we have transitioned togo mod
in 2020.db.tar
following the same instructions from here