Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/ldap: log full exception when user password set fails #5678

Merged
merged 2 commits into from
May 18, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 18, 2023

Details

Log full error for #5652
Improve logging for #5655

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 18, 2023 16:45
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a tiny nit

Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: Jens L. <jens@beryju.org>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu force-pushed the sources/ldap/log-full-exception branch from 13ba065 to 1db7987 Compare May 18, 2023 16:51
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: -38.95 ⚠️

Comparison is base (6cf7a72) 92.61% compared to head (13ba065) 53.66%.

❗ Current head 13ba065 differs from pull request most recent head 1db7987. Consider uploading reports for the commit 1db7987 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #5678       +/-   ##
===========================================
- Coverage   92.61%   53.66%   -38.95%     
===========================================
  Files         546      546               
  Lines       26195    26198        +3     
===========================================
- Hits        24259    14057    -10202     
- Misses       1936    12141    +10205     
Flag Coverage Δ
e2e 51.94% <37.50%> (+0.01%) ⬆️
integration 26.39% <25.00%> (+0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/sources/ldap/auth.py 65.22% <20.00%> (-10.86%) ⬇️
authentik/sources/ldap/signals.py 67.31% <66.67%> (-12.28%) ⬇️

... and 361 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 9c69f67 into main May 18, 2023
@BeryJu BeryJu deleted the sources/ldap/log-full-exception branch May 18, 2023 17:00
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-log-full-exception-1684429141-26b20f7
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-ldap-log-full-exception-1684429141-26b20f7-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-log-full-exception-1684429141-26b20f7

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-ldap-log-full-exception-1684429141-26b20f7-arm64

Afterwards, run the upgrade commands from the latest release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants