-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(insights): add insights tab to repo view #832
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyr4
reviewed
Jan 6, 2025
plyr4
reviewed
Jan 6, 2025
plyr4
reviewed
Jan 6, 2025
plyr4
reviewed
Jan 6, 2025
plyr4
reviewed
Jan 6, 2025
plyr4
reviewed
Jan 6, 2025
@plyr4 addressed the feedback! thanks for taking a look. |
plyr4
approved these changes
Jan 6, 2025
KellyMerrick
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a new page/tab at the repo-level called insights. it's sort of a continuation of a hackathon effort from a few years ago (hackathon/insights). the page provides repo-level metrics over the last seven days (hard coded). it does so by querying for all builds over the time span and doing client-side calculations. the metrics cover build activity, build duration, reliability, and queue time.
Important
this implementation is not final, but more-so serves as a preview and/or discussion on what this could look like while being a deploy-able deliverable. probably, in its final form, the data should be generated/stored on the backend/database with dedicated endpoints that provide the calculated data.
high-level changes:
after
parametermetrics provided:
the following are some examples based on fake build data:
insights_interactivity.mp4
Tip
Reminder for reviewers: changes in
Main.elm
,Main/Pages/Model.elm
,Main/Pages/Msg.elm
,Route/Path.elm
are auto-generated.opportunities beyond this PR: