-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: more consistent patterns generated by elm-land #781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KellyMerrick
previously approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
wass3rw3rk
reviewed
Apr 5, 2024
wass3rw3rk
previously approved these changes
Apr 12, 2024
wass3rw3rk
approved these changes
Apr 17, 2024
KellyMerrick
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching more style/pattern consistency that is generated and formatted from the
elm-land
CLI usinggenerate
:a :: b :: []
)and some code was moved elsewhere so that it wouldnt conflict with
elm-land generate
static code./Pages/Account_Authenticate.elm
and/Pages/Account_Logout.elm
(functionally identical)parsePath
toUtils.Routes
sogenerate
wont cause conflicts withRoute.elm
if we combine those changes with some tweaks to the
elm-land
CLI that I made in this fork:elm-land/elm-land@main...plyr4:elm-land-vela:main
changes:
you can actually use
elm-land generate
to build layouts and pages!then visit http://localhost:8888/org/repo/newthang
note: you need an empty
elm-land.json
in the root of the repository to runelm-land generate
:due to this line: /~https://github.com/plyr4/elm-land-vela/blob/main/projects/cli/src/effects.js#L222