release v1.9.0 #1662
release v1.9.0 #1662
Conversation
WalkthroughThis pull request updates the Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](/~https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
20-20: Consider consistent PR reference formatting.For better readability, consider using a consistent format for multiple PR references. You could either:
- Use the same hyperlink format as older entries:
[#1595](url), [#1601](url), [#1641](url)- Or keep the current format but add spaces after commas:
(#1595, #1601, #1641)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.5)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.6)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.1)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.2)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
- GitHub Check: test (windows-latest, 1.23, 5.7)
- GitHub Check: test (windows-latest, 1.23, 8.0)
- GitHub Check: test (windows-latest, 1.23, 8.4)
- GitHub Check: test (windows-latest, 1.23, 9.0)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.5)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.6)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.11)
- GitHub Check: test (macos-latest, 1.23, mariadb-11.4)
- GitHub Check: test (macos-latest, 1.23, 9.0)
🔇 Additional comments (2)
CHANGELOG.md (2)
9-9: Verify MySQL 9.0 reference.MySQL 9.0 hasn't been released yet. Consider clarifying if this is for a preview/beta version or if the version number needs to be corrected.
1-22: Well-structured changelog entry.The changelog entry is well-organized, properly categorized, and follows the project's established format. All changes are tracked with PR references, making it easy to find detailed information about each change.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
CHANGELOG.md (2)
9-9: Add a comma after "1.21+".For consistency with the formatting style used throughout the changelog, add a comma after "1.21+".
-Supported Go version is updated to Go 1.21+. (#1639) +Supported Go version is updated to Go 1.21+, (#1639)🧰 Tools
20-23: Consider adding brief impact descriptions for the changes.While the changes are well-documented, consider adding brief notes about the impact or benefit of each change. For example:
- For the error handling improvement, quantify the reduction in "busy buffer" errors if possible.
- For the
rejectReadOnlyoption enhancement, explain the benefit of handling the additional error code.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
⏰ Context from checks skipped due to timeout of 90000ms (15)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.5)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.6)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.1)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.2)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
- GitHub Check: test (windows-latest, 1.23, 5.7)
- GitHub Check: test (windows-latest, 1.23, 8.0)
- GitHub Check: test (windows-latest, 1.23, 8.4)
- GitHub Check: test (windows-latest, 1.23, 9.0)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.5)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.6)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.11)
- GitHub Check: test (macos-latest, 1.23, mariadb-11.4)
- GitHub Check: test (macos-latest, 1.23, 9.0)
🔇 Additional comments (3)
CHANGELOG.md (3)
3-3: Update the release date before merging.The date placeholder "2025-01-XX" needs to be replaced with the actual release date.
14-16: LGTM! Clear and well-documented bugfixes.The bugfixes are well-documented with clear descriptions and proper PR references.
3-23: Well-structured changelog that effectively communicates the v1.9.0 changes.The changelog follows the established format, properly categorizes changes, and includes PR references. The changes are significant enough to warrant a minor version bump (1.9.0).
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
7-9: Punctuation and Formatting Note (Static Analysis Hint)
A static analysis hint flagged a “Possible missing comma” around the bullet point for “Supported Go version is updated to Go 1.21+” preceding the VECTOR type support. In markdown bullet lists, each item is typically listed on its own line, so the punctuation is stylistically acceptable. However, please verify that the wording meets your standard documentation style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
🧰 Additional context used
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.5)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.6)
- GitHub Check: test (windows-latest, 1.23, mariadb-10.11)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.1)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.2)
- GitHub Check: test (windows-latest, 1.23, mariadb-11.4)
- GitHub Check: test (windows-latest, 1.23, 5.7)
- GitHub Check: test (windows-latest, 1.23, 8.0)
- GitHub Check: test (windows-latest, 1.23, 8.4)
- GitHub Check: test (windows-latest, 1.23, 9.0)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.5)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.6)
- GitHub Check: test (macos-latest, 1.23, mariadb-10.11)
- GitHub Check: test (macos-latest, 1.23, mariadb-11.2)
- GitHub Check: test (macos-latest, 1.23, mariadb-11.4)
- GitHub Check: test (ubuntu-latest, 1.23, mariadb-11.4)
🔇 Additional comments (4)
CHANGELOG.md (4)
3-4: New Release Header for v1.9.0 Added
The header “## v1.9.0 (2025-02-18)” looks clear and correctly formatted. Please double-check that the release date is accurate and aligns with your release schedule.
5-11: Major Changes Section Clarity and Content
The “Major Changes” section is succinctly documented with clear bullet points for the new features. It outlines key updates such as zlib compression, Go version support, VECTOR type support, and the custom dial function for the config object.🧰 Tools
12-17: Bugfixes Section Verification
The bugfix entries are well-documented. They clearly reference the fixes for authentication errors, client attribute handling, and auth switch request issues. Ensure that the corresponding issues are properly tracked on your issue tracker for future reference.
18-24: Other Changes Section Accuracy
The “Other changes” section has detailed points about logging format improvements, enhanced error handling, and specific function updates (e.g., use ofstrconv.Atoiand improvements to therejectReadOnlyoption). All entries appear clear and useful for users reviewing changelog details.
Description
Update changelog.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Improvements
max_allowed_packetparsing