Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fixes for repo topic editor #5971

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Conversation

silverwind
Copy link
Member

  • Properly hides the edit interface when saving a empty topic list
  • Align the Done button with the edit box

Before

screenshot 2019-02-05 at 19 48 56

After

screenshot 2019-02-05 at 19 48 17

- Properly hides the edit interface when saving a empty topic list
- Align the Done button with the edit box
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Feb 5, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 5, 2019
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@1772893). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #5971   +/-   ##
========================================
  Coverage          ?   38.7%           
========================================
  Files             ?     330           
  Lines             ?   48642           
  Branches          ?       0           
========================================
  Hits              ?   18827           
  Misses            ?   27088           
  Partials          ?    2727

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1772893...9d608b1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2019
@adelowo
Copy link
Member

adelowo commented Feb 5, 2019

Maybe we can add a real a cancel button rather than only hiding the editor when Done is clicked and the content is empty

@silverwind
Copy link
Member Author

silverwind commented Feb 5, 2019

When the list is empty, the user wants to clear out the list, just hiding without any action would be wrong. Now a always visible cancel button might be useful, but I'm not sure its really needed, re-saving works just fine.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2019
@lafriks lafriks merged commit 2ec9bf9 into go-gitea:master Feb 5, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants