-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Fix null pointer on not logged in attempt to Sudo #5872
Merged
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:fix-null-pointer-on-failed-login-with-sudo
Jan 28, 2019
Merged
API: Fix null pointer on not logged in attempt to Sudo #5872
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:fix-null-pointer-on-failed-login-with-sudo
Jan 28, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #5872 +/- ##
==========================================
+ Coverage 37.84% 37.85% +<.01%
==========================================
Files 328 328
Lines 48326 48326
==========================================
+ Hits 18290 18292 +2
+ Misses 27404 27401 -3
- Partials 2632 2633 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 27, 2019
lunny
approved these changes
Jan 28, 2019
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 28, 2019
adelowo
approved these changes
Jan 28, 2019
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 28, 2019
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Jan 28, 2019
…o-gitea#5872) Signed-off-by: Andrew Thornton <art27@cantab.net>
techknowlogick
added
the
backport/done
All backports for this PR have been created
label
Jan 28, 2019
zeripath
added a commit
that referenced
this pull request
Jan 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/api
This PR adds API routes or modifies them
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you attempt to sudo when you're not logged in the current implementation will cause a null pointer dereference. This PR protects the check to
ctx.User
with actx.IsSigned
check preventing this behaviour.Signed-off-by: Andrew Thornton art27@cantab.net