Fix TLS errors when using acme/autocert for local connections #5820
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upstream library
golang.org/x/crypto/acme/autocert
, a package that handles the Let's Encrypt certificate automation terminates incoming HTTP requests if the SNI (ServerName) field isn't in it's whitelist. For internal connection this domain islocalhost
which cannot be whitelisted forautocert.Manager
to automatically try to handle certificates for.This PR simply adds a
ServerName
setting toTlsClientConfig
for connections made towards localhost, thus mitigating this issue, as the certificate requested fromautocert.Manager
indeed matches the domain in its whitelist.This isn't an issue for non - Let's Encrypt setups either, and quite the opposite - in many cases should also be able to eliminate the need for
InsecureSkipVerify
.Fixes: #5800