Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent duplicate records in organizations list when creating a repository (#11303) #11325

Merged
merged 3 commits into from
May 7, 2020
Merged

Prevent duplicate records in organizations list when creating a repository (#11303) #11325

merged 3 commits into from
May 7, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented May 7, 2020 •
edited
Loading

backport #11303

@6543 @zeripath
Prevent multiple listings of organization when creating a repository (g…
7dc3817 
…o-gitea#11303)

prevent double entries in results of GetOrgsCanCreateRepoByUserID

I first try to only add GroupBy directly but xorm return broken user objects ...

... solution was to just query related UserIDs(OrgIDs) first and return OrgUsers based on this IDs

close go-gitea#11258

Co-authored-by: zeripath <art27@cantab.net>
@6543 6543 mentioned this pull request May 7, 2020
Merged
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 7, 2020
@zeripath zeripath added this to the 1.11.5 milestone May 7, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 7, 2020
@zeripath
Copy link
Contributor

zeripath commented May 7, 2020

make lg-tm work

@zeripath zeripath merged commit cd7fa15 into go-gitea:release/v1.11 May 7, 2020
@6543 6543 deleted the backport_11303 branch May 7, 2020 21:45
@zeripath zeripath changed the title Prevent multiple listings of organization when creating a repository (#11303) Prevent duplicate records in organizations list when creating a repository (#11303) May 8, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.5
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @zeripath @lafriks @GiteaBot