Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up loading of large files when guessing format #1920

Merged
merged 4 commits into from
Jan 25, 2019

Conversation

astrofrog
Copy link
Member

This adds a shortcut if loading a large file that isn't a FITS file. Previously astropy would try and load the whole file as a header.

@astrofrog astrofrog added the bug label Jan 17, 2019
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #1920 into master will decrease coverage by 0.04%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
- Coverage   85.64%   85.59%   -0.05%     
==========================================
  Files         236      236              
  Lines       21044    21072      +28     
==========================================
+ Hits        18023    18037      +14     
- Misses       3021     3035      +14
Impacted Files Coverage Δ
glue/core/data_factories/fits.py 87.68% <90%> (-1.39%) ⬇️
glue/app/qt/mdi_area.py 60% <0%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39333e9...b149ddd. Read the comment docs.

@astrofrog astrofrog merged commit e8e2088 into glue-viz:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant