Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for datetime64 dtype #1510

Merged
merged 17 commits into from
Feb 5, 2018
Merged

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Feb 1, 2018

This adds support for having Numpy datetime64 components in Data objects, and also updates the Matplotlib viewers to properly support this and show date/time labels.

@rsangole - feel free to try out this branch if you are familiar with git! (otherwise this will be available in the developer conda package for glue shortly after this is merged). Just to clarify, this never actually worked properly before - what you saw before was that datetime columns got converted to strings and glue would then show it as a categorical component, but the points were not actually properly spaced in time.

NOTE: selections don't work yet, I'm working on fixing that

Remaining TODOs:

  • Add test of making a viewer with datetime data and modifying the xmin/xmax limits
  • Add test of saving/reloading session
  • Add documentation about this
  • Add changelog entry

Fixes #1490

@astrofrog astrofrog added this to the v0.13.0 milestone Feb 1, 2018
@astrofrog astrofrog changed the title Add support for datetime64 dtype WIP: Add support for datetime64 dtype Feb 1, 2018
@astrofrog astrofrog changed the title WIP: Add support for datetime64 dtype Add support for datetime64 dtype Feb 5, 2018
…e explicitly 64-bit to make sure it works on 32-bit platforms
@astrofrog astrofrog merged commit a79a0a2 into glue-viz:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph no longer shows date-time axis correctly
1 participant