feat: duplicates in portalicious #6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aberonni
changed the title
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
e178753 to
48a5ec9
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
48a5ec9 to
160241e
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
160241e to
900ebd3
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
900ebd3 to
d856af3
Compare
aberonni
added a commit
that referenced
this pull request
Feb 18, 2025
AB#33731 This makes sure that we invalidate cache for registration queries that rely on referenceId, as well as the queries that rely on registration.id This was causing issues because the new "getDuplicates" endpoint (implemented in #6522) uses referenceId, and the cache for it was not being invalidated after editing personal information.
4 tasks
aberonni
added a commit
that referenced
this pull request
Feb 18, 2025
AB#33731 This makes sure that we invalidate cache for registration queries that rely on referenceId, as well as the queries that rely on registration.id This was causing issues because the new "getDuplicates" endpoint (implemented in #6522) uses referenceId, and the cache for it was not being invalidated after editing personal information.
aberonni
force-pushed
the
feat.duplicates
branch
from
d4388ae to
60d052e
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
d856af3 to
95d0d7a
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
95d0d7a to
68a74f9
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
68a74f9 to
1ccb23e
Compare
aberonni
had a problem deploying
to
client-ethiopia
GitHub Actions
Failure
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
d07a910 to
5190654
Compare
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
5190654 to
d093bfe
Compare
AB#33536 AB#33535
* chore: add E2E tests for duplicate registrations * PR review
aberonni
force-pushed
the
aberonni/duplicate-registrations-banner
branch
from
a78a068 to
2d02e23
Compare
4 tasks
RubenGeo
requested changes
Feb 27, 2025
...alicious/src/app/components/registration-page-layout/registration-page-layout.component.html
Outdated
Show resolved
Hide resolved
...rtalicious/src/app/components/registration-page-layout/registration-page-layout.component.ts
Outdated
Show resolved
Hide resolved
RubenGeo
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#33536 AB#33535
Checklist before requesting a review
Portalicious preview deployment
https://lively-river-04adce503-6522.westeurope.5.azurestaticapps.net