Fix allow empty string values for nonRequired dropdows #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenGeo
commented
Jan 28, 2025
services/121-service/src/registration/validators/registrations-input-validator.ts
Show resolved
Hide resolved
RubenGeo
commented
Jan 28, 2025
services/121-service/test/registrations/bulk-update-registration.test.ts
Show resolved
Hide resolved
RubenGeo
commented
Jan 28, 2025
services/121-service/test/registrations/bulk-update-registration.test.ts
Show resolved
Hide resolved
PeterSmallenbroek
approved these changes
Jan 29, 2025
services/121-service/test/registrations/bulk-update-registration.test.ts
Show resolved
Hide resolved
PeterSmallenbroek
force-pushed
the
fix.empty-dropwdown-import-registration
branch
from
fb18dd5 to
6d7aa1f
Compare
PeterSmallenbroek
temporarily deployed
to
test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#33084 AB#33082
Describe your changes
See github comments in the code
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.