Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB#32984 Seed admin only #6422

Merged
merged 1 commit into from
Jan 27, 2025
Merged

AB#32984 Seed admin only #6422

merged 1 commit into from
Jan 27, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jan 27, 2025 •
edited
Loading

AB#32984

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@Copilot Copilot bot review requested due to automatic review settings January 27, 2025 09:35
@RubenGeo RubenGeo added the chore Something that does not affect the end user label Jan 27, 2025
Copilot
Copilot AI reviewed Jan 27, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

services/121-service/src/scripts/scripts.service.ts:31

  • The new behavior for 'seedAdminOnly' should be covered by tests to ensure it works as expected.
if (seedConfig.seedAdminOnly) {
@RubenGeo RubenGeo requested a review from elwinschmitz January 27, 2025 09:50
@RubenGeo RubenGeo enabled auto-merge (squash) January 27, 2025 09:50
@RubenGeo RubenGeo force-pushed the feat.seed-production-initial-state branch from aaf0e3f to d65d733 Compare January 27, 2025 10:39
@RubenGeo RubenGeo merged commit f721ba0 into main Jan 27, 2025
6 checks passed
@RubenGeo RubenGeo deleted the feat.seed-production-initial-state branch January 27, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@elwinschmitz elwinschmitz elwinschmitz approved these changes

Assignees
No one assigned
Labels
chore Something that does not affect the end user
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RubenGeo @elwinschmitz