Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portalicious: store selected columns #6400

Merged
merged 5 commits into from
Jan 21, 2025
Merged

portalicious: store selected columns #6400

merged 5 commits into from
Jan 21, 2025

Conversation

PeterSmallenbroek
Copy link
Contributor

@PeterSmallenbroek PeterSmallenbroek commented Jan 20, 2025 •
edited
Loading

AB#32583

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6400.westeurope.5.azurestaticapps.net

@PeterSmallenbroek PeterSmallenbroek added the portalicious [DEPRECATED] Changes related to the Portalicious release label Jan 20, 2025
@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from 80ad37c to f27ec29 Compare January 20, 2025 09:36
@PeterSmallenbroek PeterSmallenbroek enabled auto-merge (squash) January 20, 2025 09:42
@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from f27ec29 to c4974d1 Compare January 20, 2025 10:56
@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from c4974d1 to d8e7b7e Compare January 20, 2025 10:59
@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from 34d4a31 to ae6e925 Compare January 20, 2025 15:14
@PeterSmallenbroek PeterSmallenbroek marked this pull request as draft January 20, 2025 15:14
auto-merge was automatically disabled January 20, 2025 15:14

Pull request was converted to draft

@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from 43f616e to ec4065a Compare January 21, 2025 08:29
@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from ec4065a to 4fea7d7 Compare January 21, 2025 08:33
@PeterSmallenbroek PeterSmallenbroek marked this pull request as ready for review January 21, 2025 08:34
aberonni
aberonni requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@aberonni aberonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer!

@PeterSmallenbroek PeterSmallenbroek enabled auto-merge (squash) January 21, 2025 09:35
@PeterSmallenbroek PeterSmallenbroek force-pushed the feat.portalicious-store-selected-columns branch from 617328c to e35063a Compare January 21, 2025 09:36
aberonni
aberonni previously approved these changes Jan 21, 2025
View reviewed changes
@PeterSmallenbroek PeterSmallenbroek merged commit 6dd54c9 into main Jan 21, 2025
6 checks passed
@PeterSmallenbroek PeterSmallenbroek deleted the feat.portalicious-store-selected-columns branch January 21, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aberonni aberonni aberonni approved these changes

Assignees
No one assigned
Labels
portalicious [DEPRECATED] Changes related to the Portalicious release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeterSmallenbroek @aberonni