Change error checks in K6 tests #6390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piotrk39
force-pushed
the
fix.correct-errors-in-k6-branch
branch
from
330fe27 to
46ecc30
Compare
RubenGeo
force-pushed
the
fix.k6-error-message
branch
from
66855af to
dd5222d
Compare
Piotrk39
force-pushed
the
fix.correct-errors-in-k6-branch
branch
from
b4efb8b to
0da8aed
Compare
elwinschmitz
force-pushed
the
fix.k6-error-message
branch
from
dd5222d to
fd59993
Compare
Piotrk39
force-pushed
the
fix.correct-errors-in-k6-branch
branch
from
7d0811d to
f8d2585
Compare
RubenGeo
requested changes
Jan 21, 2025
Piotrk39
force-pushed
the
fix.correct-errors-in-k6-branch
branch
from
3e36c52 to
7b96678
Compare
|
@RubenGeo All tests should be passing now as expected. There is one more issue connected with the K6 tests and it is that they do not fail after threshold of requests is breached e.g if we have threshold for failed_requests set to 30 percent after this is breached then we still can see pass in the outcome of the test. For now we should only rely on the failed checks. |
RubenGeo
previously approved these changes
Jan 24, 2025
Piotrk39
force-pushed
the
fix.correct-errors-in-k6-branch
branch
from
02ba084 to
db2cdad
Compare
RubenGeo
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#32606
Describe your changes
Due to the bug that caused the message from K6 runs to be always "passed" the tests additionally need better error handling where more checks are displayed and validated through the run of load/ performance tests.
Checklist before requesting a review
Portalicious preview deployment
This PR does not have any preview deployments yet.