Refactor: FSP reconciliation module

[RubenGeo]

AB#32623

Describe your changes

Checklist before requesting a review

• I have performed a self-review of my code
• I have added tests wherever relevant
• I have made sure that all automated checks pass before requesting a review
• I do not need any deviation from our PR guidelines

Portalicious preview deployment

https://lively-river-04adce503-6382.westeurope.5.azurestaticapps.net

Copilot reviewed 26 out of 41 changed files in this pull request and generated no comments.

Files not reviewed (15)

• services/121-service/src/financial-service-provider-callback-job-processors/financial-service-provider-callback-job-processors.module.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/intersolve-voucher/services/intersolve-voucher-cron.service.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/safaricom/safaricom.service.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/safaricom/safaricom.service.spec.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/commercial-bank-ethiopia/commercial-bank-ethiopia.service.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.service.ts: Evaluated as low risk
• services/121-service/src/financial-service-provider-callback-job-processors/processors/safaricom-transfer-callback-job.processor.ts: Evaluated as low risk
• services/121-service/src/financial-service-provider-callback-job-processors/processors/safaricom-timeout-callback-job.processor.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/intersolve-visa/intersolve-visa.module.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/commercial-bank-ethiopia/commercial-bank-ethiopia.controller.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/intersolve-voucher/intersolve-voucher.service.ts: Evaluated as low risk
• services/121-service/src/payments/payments.controller.ts: Evaluated as low risk
• interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/intersolve-voucher/intersolve-voucher.controller.ts: Evaluated as low risk
• services/121-service/src/payments/fsp-integration/excel/excel.service.ts: Evaluated as low risk

[diderikvw]

Looks really good. For FSPs that are not yet refactored, I just glanced over the moved code, but did not look if the code is clean, as we will get to that later.

[diderikvw]

Just 1 small thing, IMO could be a bit cleaner.