Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic attributes api test filtering all of them #6362

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jan 8, 2025

AB#32508

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@RubenGeo RubenGeo added the chore Something that does not affect the end user label Jan 8, 2025
@Copilot Copilot bot review requested due to automatic review settings January 8, 2025 12:45
@RubenGeo RubenGeo force-pushed the chore.api-test-all-generic-attributes branch from 89ab643 to aadafa6 Compare January 8, 2025 12:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

services/121-service/test/registrations/pagination/filter-registration.test.ts:150

  • The error message should include additional context such as programId and attribute.group for better debugging. Suggested change: throw new Error(No filterAssertionConfig found for attribute: ${attribute.name} in program: ${programId}, group: ${attribute.group});
throw new Error(`No filterAssertionConfig found for attribute: ${attribute.name}`);
@RubenGeo RubenGeo force-pushed the chore.api-test-all-generic-attributes branch from aadafa6 to 5f02e28 Compare January 9, 2025 10:12
@PeterSmallenbroek PeterSmallenbroek force-pushed the chore.api-test-all-generic-attributes branch from 5f02e28 to 2bf0002 Compare January 9, 2025 12:54
@PeterSmallenbroek PeterSmallenbroek enabled auto-merge (squash) January 9, 2025 12:58
@PeterSmallenbroek PeterSmallenbroek merged commit 0dd668c into main Jan 9, 2025
3 checks passed
@PeterSmallenbroek PeterSmallenbroek deleted the chore.api-test-all-generic-attributes branch January 9, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants