Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K6 floating point test visa #6356

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Jan 7, 2025

AB#32515

Describe your changes

Only merge if this run is succesful

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

Portalicious preview deployment

This PR does not have any preview deployments yet.

@RubenGeo RubenGeo added the chore Something that does not affect the end user label Jan 7, 2025
@Copilot Copilot bot review requested due to automatic review settings January 7, 2025 10:28

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

k6/tests/payment100kRegistrationOCW.js:14

  • Ensure that the new behavior introduced by the 'amount' parameter is covered by tests.
const amount = 11.11;

k6/models/initalize-payment.js:0

  • The file name 'initalize-payment.js' is misspelled. It should be 'initialize-payment.js'.
initalize-payment.js
@RubenGeo
Copy link
Contributor Author

RubenGeo commented Jan 10, 2025

It seems to have run in a normal time frame: /~https://github.com/global-121/121-platform/actions/runs/12708513028 @PeterSmallenbroek

@PeterSmallenbroek PeterSmallenbroek enabled auto-merge (squash) January 13, 2025 11:59
@PeterSmallenbroek PeterSmallenbroek force-pushed the fix.k6-test-floating-point-visa branch from 129dcd7 to 6c33251 Compare January 13, 2025 11:59
@PeterSmallenbroek PeterSmallenbroek merged commit 99b50da into main Jan 13, 2025
6 checks passed
@PeterSmallenbroek PeterSmallenbroek deleted the fix.k6-test-floating-point-visa branch January 13, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Something that does not affect the end user
Development

Successfully merging this pull request may close these issues.

2 participants