Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/v24.12 5 #6311

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Hotfix/v24.12 5 #6311

merged 1 commit into from
Dec 19, 2024

Conversation

RubenGeo
Copy link
Contributor

@RubenGeo RubenGeo commented Dec 19, 2024

AB#32317

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 09:00
@RubenGeo RubenGeo added the bugfix Something that affects our end users is fixed label Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 14 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • services/.env.example: Language not supported
  • services/121-service/package.json: Language not supported
  • .github/dependabot.yml: Evaluated as low risk
  • services/121-service/src/financial-service-providers/enum/financial-service-provider-name.enum.ts: Evaluated as low risk
  • services/121-service/src/financial-service-providers/financial-service-providers-settings.const.ts: Evaluated as low risk
  • services/121-service/src/main.ts: Evaluated as low risk
  • services/121-service/src/payments/payments.service.ts: Evaluated as low risk
  • services/121-service/src/registration/modules/registration-data/registration-data.module.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

services/121-service/src/shared/middleware/azure-logger.middleware.ts:42

  • The error message contains a spelling mistake. 'occured' should be 'occurred'.
console.error('An error occured in AzureLoggerMiddleware::flushLogs:', flushError);

services/121-service/src/shared/services/custom-http.service.ts:252

  • The word 'occured' is misspelled. It should be 'occurred'.
console.error(`An error occured in CustomHttpService::${methodName}:`, flushError);
@RubenGeo RubenGeo merged commit ac00d1e into main Dec 19, 2024
10 checks passed
tijsziere pushed a commit that referenced this pull request Dec 19, 2024
Jumbo missing fix

Co-authored-by: Ruben <vandervalk@geoit.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something that affects our end users is fixed
Development

Successfully merging this pull request may close these issues.

2 participants