Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make make programFspConfigId nullable in relations AB#32262 #6306

Merged
merged 1 commit into from
Jan 24, 2025
Merged

fix: make make programFspConfigId nullable in relations AB#32262 #6306

merged 1 commit into from
Jan 24, 2025

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Dec 18, 2024 •
edited by azure-boards bot
Loading

AB#32262

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@jannisvisser jannisvisser added the bugfix Something that affects our end users is fixed label Dec 18, 2024
RubenGeo
RubenGeo requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@RubenGeo RubenGeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the PR I made to this branch

@RubenGeo
Copy link
Contributor

I think we should wait for this task before we merge this.

@jannisvisser jannisvisser force-pushed the fix.program-fsp-config-nullable-FK branch from 9f0ee7b to ae76dec Compare January 3, 2025 12:10
@jannisvisser
Copy link
Contributor Author

@RubenGeo you still need to get this PR merged (I see the item is already on 'to accept'). The PR you just merged was a sub-PR.

@jannisvisser jannisvisser force-pushed the fix.program-fsp-config-nullable-FK branch from 0ff50a0 to 0e020fe Compare January 6, 2025 08:49
@RubenGeo RubenGeo force-pushed the fix.program-fsp-config-nullable-FK branch from 0e020fe to 2dc111c Compare January 8, 2025 13:00
@RubenGeo RubenGeo enabled auto-merge (squash) January 8, 2025 13:01
@RubenGeo RubenGeo force-pushed the fix.program-fsp-config-nullable-FK branch from 2dc111c to b32b92d Compare January 9, 2025 09:22
@RubenGeo RubenGeo force-pushed the fix.program-fsp-config-nullable-FK branch from b32b92d to d998e83 Compare January 24, 2025 13:40
@RubenGeo RubenGeo merged commit a129cca into main Jan 24, 2025
7 checks passed
@RubenGeo RubenGeo deleted the fix.program-fsp-config-nullable-FK branch January 24, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenGeo RubenGeo RubenGeo approved these changes

Assignees
No one assigned
Labels
bugfix Something that affects our end users is fixed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannisvisser @RubenGeo