-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portalicious: import reconciliation data #6283
Conversation
c83c6c1
to
38503a7
Compare
4f29cb5
to
7b8cbd7
Compare
7b8cbd7
to
916121d
Compare
916121d
to
c9c3893
Compare
c9c3893
to
c0fc72e
Compare
c0fc72e
to
4a15a67
Compare
3dcafe5
to
363ac1e
Compare
4a15a67
to
aa2493b
Compare
aa2493b
to
b530047
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (12)
- interfaces/Portalicious/src/app/components/file-upload-control/file-upload-control.component.html: Language not supported
- interfaces/Portalicious/src/app/components/import-file-dialog/import-file-dialog.component.html: Language not supported
- interfaces/Portalicious/src/app/pages/project-payment/components/import-reconciliation-data/import-reconciliation-data.component.html: Language not supported
- interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.html: Language not supported
- interfaces/Portalicious/src/app/pages/project-registrations/components/import-registrations/import-registrations.component.html: Language not supported
- interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
- interfaces/Portalicious/src/locale/messages.xlf: Language not supported
- interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-registrations/components/import-registrations/import-registrations.component.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/services/download.service.ts: Evaluated as low risk
- interfaces/Portalicious/src/app/pages/project-payment/components/single-payment-export/single-payment-export.component.ts: Evaluated as low risk
- interfaces/Portalicious/eslint.config.js: Evaluated as low risk
Comments suppressed due to low confidence (3)
interfaces/Portalicious/src/app/components/import-file-dialog/import-file-dialog.component.ts:51
- The use of 'any' type should be avoided. Consider using a more specific type instead.
input.required<CreateMutationResult<any, Error, any, any>>();
interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts:116
- Ensure that the new method
getReconciliationDataTemplates
is covered by tests.
getReconciliationDataTemplates(projectId: Signal<number>) {
interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts:126
- Ensure that the new method
importReconciliationData
is covered by tests.
importReconciliationData({
b530047
to
fb34b08
Compare
fb34b08
to
d2e8c49
Compare
AB#32154 AB#32158
d2e8c49
to
1171c1e
Compare
AB#32154 AB#32158
Checklist before requesting a review