Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portalicious: import reconciliation data #6283

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

aberonni
Copy link
Contributor

@aberonni aberonni commented Dec 12, 2024

AB#32154 AB#32158

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@aberonni aberonni force-pushed the aberonni/portalicious-retry-transfers branch 2 times, most recently from c83c6c1 to 38503a7 Compare December 14, 2024 09:54
Base automatically changed from aberonni/portalicious-retry-transfers to main December 14, 2024 10:01
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from 4f29cb5 to 7b8cbd7 Compare December 18, 2024 07:54
@aberonni aberonni added the portalicious Changes related to the portalicious release label Dec 18, 2024
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from 7b8cbd7 to 916121d Compare December 18, 2024 09:47
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from 916121d to c9c3893 Compare December 18, 2024 10:47
@aberonni aberonni changed the base branch from main to arsforza/portalicious.single-payment-exports December 18, 2024 14:52
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from c9c3893 to c0fc72e Compare December 18, 2024 15:00
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from c0fc72e to 4a15a67 Compare December 18, 2024 15:04
@elwinschmitz elwinschmitz force-pushed the arsforza/portalicious.single-payment-exports branch from 3dcafe5 to 363ac1e Compare December 19, 2024 08:31
Base automatically changed from arsforza/portalicious.single-payment-exports to main December 19, 2024 08:38
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from 4a15a67 to aa2493b Compare December 19, 2024 10:35
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from aa2493b to b530047 Compare December 19, 2024 10:37
@aberonni aberonni marked this pull request as ready for review December 19, 2024 10:37
@Copilot Copilot bot review requested due to automatic review settings December 19, 2024 10:37

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 17 changed files in this pull request and generated no comments.

Files not reviewed (12)
  • interfaces/Portalicious/src/app/components/file-upload-control/file-upload-control.component.html: Language not supported
  • interfaces/Portalicious/src/app/components/import-file-dialog/import-file-dialog.component.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-payment/components/import-reconciliation-data/import-reconciliation-data.component.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.html: Language not supported
  • interfaces/Portalicious/src/app/pages/project-registrations/components/import-registrations/import-registrations.component.html: Language not supported
  • interfaces/Portalicious/src/locale/messages.nl.xlf: Language not supported
  • interfaces/Portalicious/src/locale/messages.xlf: Language not supported
  • interfaces/Portalicious/src/app/pages/project-payment/project-payment.page.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-registrations/components/import-registrations/import-registrations.component.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/services/download.service.ts: Evaluated as low risk
  • interfaces/Portalicious/src/app/pages/project-payment/components/single-payment-export/single-payment-export.component.ts: Evaluated as low risk
  • interfaces/Portalicious/eslint.config.js: Evaluated as low risk
Comments suppressed due to low confidence (3)

interfaces/Portalicious/src/app/components/import-file-dialog/import-file-dialog.component.ts:51

  • The use of 'any' type should be avoided. Consider using a more specific type instead.
input.required<CreateMutationResult<any, Error, any, any>>();

interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts:116

  • Ensure that the new method getReconciliationDataTemplates is covered by tests.
getReconciliationDataTemplates(projectId: Signal<number>) {

interfaces/Portalicious/src/app/domains/payment/payment.api.service.ts:126

  • Ensure that the new method importReconciliationData is covered by tests.
importReconciliationData({
@arsforza arsforza self-requested a review December 19, 2024 10:45
@aberonni aberonni force-pushed the aberonni/portalicious-reconciliation-data branch from b530047 to fb34b08 Compare December 19, 2024 13:36
arsforza
arsforza previously approved these changes Dec 19, 2024
@aberonni aberonni merged commit e49981c into main Dec 20, 2024
5 checks passed
@aberonni aberonni deleted the aberonni/portalicious-reconciliation-data branch December 20, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portalicious Changes related to the portalicious release
Development

Successfully merging this pull request may close these issues.

3 participants