Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor.cascade delete #6253

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Refactor.cascade delete #6253

merged 5 commits into from
Dec 16, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Dec 6, 2024 •
edited
Loading

AB#26365

Describe your changes

See descriptions in devops tasks.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review
  • I do not need any deviation from our PR guidelines

@jannisvisser jannisvisser added the bugfix Something that affects our end users is fixed label Dec 6, 2024
@jannisvisser
Copy link
Contributor Author

failing Test Service: Code is because of #6252 that needs to be merged

@RubenGeo RubenGeo force-pushed the refactor.cascade-delete branch from ed4e48b to 2c66025 Compare December 10, 2024 10:35
RubenGeo
RubenGeo requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@RubenGeo RubenGeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to add some testing on this? Like deleting the program to see if that keeps working?

Edit: I found that there was a task open for this

services/121-service/src/events/entities/event.entity.ts Outdated Show resolved Hide resolved
jannisvisser and others added 4 commits December 16, 2024 07:53
@jannisvisser @RubenGeo
refactor: use onDelete: CASCADE instead of @BeforeRemove
f4bd76a
@jannisvisser @RubenGeo
chore: custom estlint package to check typeorm relations
14b996b
@RubenGeo @jannisvisser
Delete program api test (#6275)
89000ff 
* Delete program api test

* Fix typechecks

Signed-off-by: Ruben <vandervalk@geoit.nl>

* Also delete cbe program

Signed-off-by: Ruben <vandervalk@geoit.nl>

* Update services/121-service/test/program/delete-program.test.ts

---------

Signed-off-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: jannisvisser <jannisvisser@redcross.nl>
@jannisvisser @RubenGeo
Refactor.cascade delete check all relations (#6286)
89cbecc 
* fix: evaluate onDelete: cascade and nullable:true AB#31938 AB#32189

* fix: unit test
@RubenGeo RubenGeo force-pushed the refactor.cascade-delete branch from bfec419 to 89cbecc Compare December 16, 2024 06:53
@RubenGeo
Refactor.cascade delete cleanup training demo (#6291)
80ccba7 
Cleanup nullable demo/training

Signed-off-by: Ruben <vandervalk@geoit.nl>
Co-authored-by: Ruben <vandervalk@geoit.nl>
@jannisvisser jannisvisser enabled auto-merge (squash) December 16, 2024 07:47
@jannisvisser jannisvisser merged commit 5ae6946 into main Dec 16, 2024
7 checks passed
@jannisvisser jannisvisser deleted the refactor.cascade-delete branch December 16, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RubenGeo RubenGeo RubenGeo approved these changes

Assignees
No one assigned
Labels
bugfix Something that affects our end users is fixed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jannisvisser @RubenGeo