Better error on creating users #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenGeo
force-pushed
the
fix.username-message
branch
from
2c6e4ec to
f3ceef5
Compare
RubenGeo
force-pushed
the
fix.username-message
branch
from
f3ceef5 to
c489256
Compare
elwinschmitz
reviewed
Dec 5, 2024
There was a problem hiding this comment.
This endpoint fits within the "stricter rate-limits"-set, right?
Because with this error (also the original error), you could "find out" if certain accounts exist on the system already...
But having no information on an error for the Cash IM users would also not be very helpful...
But still, in essence, this change doesn't really make the already existing 'vulnerability' any greater.. As you're only returning data that's been provided in the request. Its only "more convenient"...
elwinschmitz
approved these changes
Dec 5, 2024
|
Very point Elwin. But considering this is an Organiaztion admin only endpoint it's fine. As that user can already read all users in the system. If we make an open endpoint like this we should reconsider |
RubenGeo
force-pushed
the
fix.username-message
branch
from
c489256 to
57ac249
Compare
Signed-off-by: Ruben <vandervalk@geoit.nl>
RubenGeo
force-pushed
the
fix.username-message
branch
from
57ac249 to
2cfc0f8
Compare
|
Ah, yes. Even better. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#31950
Describe your changes
Checklist before requesting a review