Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New git-lfs version] v3.6.0 #5266

Closed
github-actions bot opened this issue Nov 21, 2024 · 1 comment · Fixed by git-for-windows/build-extra#581
Closed

[New git-lfs version] v3.6.0 #5266

github-actions bot opened this issue Nov 21, 2024 · 1 comment · Fixed by git-for-windows/build-extra#581

Comments

@github-actions
Copy link

/~https://github.com/git-lfs/git-lfs/releases/tag/v3.6.0

@dscho
Copy link
Member

dscho commented Nov 21, 2024

/open pr

The workflow run was started

dscho added a commit to dscho/git-for-windows-automation that referenced this issue Nov 28, 2024
It has been reported in
git-for-windows/git#5276 (comment)
that the Git LFS link in the release notes was incorrect.

The reason is that we have some special handling of Git LFS so that we
do not get the (rather ugly) _tag_ URL but instead the _release_ URL.

Example: git-for-windows/git#5266 refers to
/~https://github.com/git-lfs/git-lfs/releases/tag/v3.6.0 because this is
the URL from the feed from which the `monitor-components` gets it:
/~https://github.com/git-for-windows/git/blob/v2.47.1.windows.1/.github/workflows/monitor-components.yml#L29-L3

The corresponding PR at
git-for-windows/build-extra#581 (opened via
`/open pr` at
git-for-windows/git#5266 (comment))
has the link /~https://github.com/git-lfs/git-lfs/releases/tag/3.6.0 (note
the missing `v` after the last slash).

This commit ensures that future `/open pr`s in Git LFS issues will use
the correct link.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant