-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a workflow to break a pacman upload lease #86
Conversation
This could probably almost run on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
I just have one question regarding the need to set up a minimal Git for Windows SDK. It's a minor concern, though, I'd be fine with merging as-is.
- uses: git-for-windows/setup-git-for-windows-sdk@v1 | ||
with: | ||
flavor: minimal | ||
architecture: x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need the minimal SDK? As far as I can tell, pacman-helper.sh break_lock
simply hands off to wingit-snapshost-helper.sh
, which calls curl
. GitHub workflows' bash
steps use Git for Windows' Bash (!!!), which is distributed with a working curl
, so it should work out of the box.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also use date
, xxd
, tr
, sed
, base64
, cygpath
and openssl
, but that should work.
We may want to change those scripts so that they use That way, we can use them also in |
@rimrul I opened git-for-windows/build-extra#566 (ran it in Linux to verify that it works; It said "409 There is currently no lease on the blob." of course 😁); How do you feel about merging that first and then switching this here GitHub workflow to |
To prevent parallel uploads of pacman packages from interfering with each other Git for Windows uses Azure blobs leases without a timeout. Sometimes it's necessary to manually break such a lease if a job acquired a lease and failed to release it. We can do that via the pacman-helper script[1], but having it available as a GitHub workflow or eventually a slash command makes this easier to dispatch. This fixes git-for-windows#40 [1] git-for-windows/build-extra#488 Signed-off-by: Matthias Aßhauer <mha1993@live.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah!
This fixes #40