Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid sharing cygheap between msys2 runtime versions #77

Conversation

dscho
Copy link
Member

@dscho dscho commented Jan 31, 2023

This is a companion to git-for-windows/msys2-runtime#48 and is designed to fix git-for-windows/git#4255

@dscho dscho self-assigned this Jan 31, 2023
dscho added 3 commits January 31, 2023 15:33
Seems that sourceware currently has trouble:

  Cloning into bare repository '/d/a/MSYS2-packages/MSYS2-packages/msys2-runtime/msys2-runtime'...
  fatal: unable to connect to sourceware.org:
  sourceware.org[0: 8.43.85.97]: errno=Connection timed out
  sourceware.org[1: 2620:52:3:1:0:246e:9693:128c]: errno=Network is unreachable

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…e versions

When calling, say, a Cygwin Bash (or even a regular MSYS2 Bash, or even
a MinGit Bash of a different Git for Windows version), it is possible
that the MSYS2 runtime of the called Bash is incompatible with the MSYS2
runtime of the caller. When that happens, all kinds of chaos can ensue.

One possible symptom is that the MSYS2 runtime aborts with the error
message "cygheap base mismatch detected".

Another possible symptom is that the MSYS2 runtime (or the Cygwin
runtime) exits silently, with exit code 127 (which is misleading as that
exit code is reserved to imply that an executable could not be found).

With this patch, we try harder to prevent such a thing from happening.

This is a companion to git-for-windows/msys2-runtime#48

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho force-pushed the avoid-sharing-cygheap-between-msys2-runtime-versions branch from 79bc8a7 to c7734e1 Compare January 31, 2023 14:33
@dscho
Copy link
Member Author

dscho commented Jan 31, 2023

/deploy msys2-runtime

The x86_64 and the i686 workflow runs were started.

@dscho dscho merged commit 82a86e5 into git-for-windows:main Jan 31, 2023
@dscho dscho deleted the avoid-sharing-cygheap-between-msys2-runtime-versions branch January 31, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MinGit can be incompatible with Git for Windows installation of the same bitness
1 participant