Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For frame compositing, defer initial histogram query #1225

Closed
manthey opened this issue Jun 27, 2023 · 0 comments · Fixed by #1227
Closed

For frame compositing, defer initial histogram query #1225

manthey opened this issue Jun 27, 2023 · 0 comments · Fixed by #1227
Assignees
@annehaley

Comments

@manthey
Copy link
Member

manthey commented Jun 27, 2023

With the recent frame controls, we now always make a histogram query. For images that don't have multiple frames, it will be uncommon to want this data and it would be better to not make an initial histogram query.
@manthey manthey assigned manthey and annehaley and unassigned manthey Jun 27, 2023
manthey added a commit that referenced this issue Jun 28, 2023
@manthey
Fix updating the hidden style field for the frame selector
889491c 
This ensure it maintains reactivity and updates for just the current
mode, including clearing for non-compositing modes.

Resolves #1225.

Sets default band names more appropriately when there are other than 3
bands.
@manthey manthey mentioned this issue Jun 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@annehaley annehaley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix updating the hidden style field for the frame selector girder/large_image
2 participants
@manthey @annehaley