feat(notification): informer les abonnés des nouvelles questions dans un forum #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
changed the title
vincentporte
force-pushed
the
718-notification-informer-les-abonnes-dun-forum-des-nouvelles-questions
branch
from
cf7ce5d to
948e184
Compare
…tor tests in pytest style
vincentporte
force-pushed
the
718-notification-informer-les-abonnes-dun-forum-des-nouvelles-questions
branch
from
948e184 to
6f46bd7
Compare
vincentporte
requested review from
calummackervoy,
francoisfreitag and
leo-naeka
francoisfreitag
approved these changes
Dec 2, 2024
| def test_posts_upvoters_are_notified_on_replies(self, db, upvoters): | ||
| topic = TopicFactory(with_post=True) | ||
| PostFactory(topic=topic, upvoted_by=upvoters) | ||
| assert set([upvoter.email for upvoter in upvoters]).issubset(set(topic.mails_to_notify())) |
There was a problem hiding this comment.
Pourquoi ne pas vérifier qu’ils contiennent les mêmes éléments ?
There was a problem hiding this comment.
Lors de réponses, tous les posters sont notifiés, sauf le dernier, en plus des upvoters. J'avais le choix entre faire un très gros test exhaustifs un peu complexe à mettre en place, et tester par type d'utilisateurs à notifier.
J'ai préféré l'option 2
vincentporte
deleted the
718-notification-informer-les-abonnes-dun-forum-des-nouvelles-questions
branch
vincentporte
pushed a commit
that referenced
this pull request
Dec 16, 2024
🤖 I have created a release *beep* *boop* --- ## [2.19.0](v2.18.0...v2.19.0) (2024-12-16) ### Features * amélioration bouton pro_connect ([#847](#847)) ([09397af](09397af)) * harmonisation des liens de connexion ([#844](#844)) ([fb50472](fb50472)) * **home:** afficher les questions en attente de réponse sur la page d'accueil ([#830](#830)) ([300a7bd](300a7bd)) * mise à jour de la politique de confidentialité ([#845](#845)) ([fa5d0d4](fa5d0d4)) * **notification:** informer les abonnés des nouvelles questions dans un forum ([#835](#835)) ([432fec2](432fec2)) * POC, autoconnection les emplois vers la commu via Pro Connect ([#851](#851)) ([56e3163](56e3163)) * renommage des upvotes ([#842](#842)) ([4491d8d](4491d8d)) ### Bug Fixes * hydratation du parametre `next` dans l'url proconnect:authorize ([#850](#850)) ([3486f6e](3486f6e)) * **stats:** desactivation de la collecte des stats automatique ([#859](#859)) ([5bf3aea](5bf3aea)) --- This PR was generated with [Release Please](/~https://github.com/googleapis/release-please). See [documentation](/~https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Informer les utilisateurs abonnés à un forum lorsqu'une nouvelle question est posée
🎸 La notification est incluse dans le digest quotidien
🎸 Le
EmailSentTrackKinddu digest quotidien est désormaisBULK_NOTIFSType de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
Points d'attention
🦺 refactor des tests impactés en pytest
🦺 ajout de
TraitàNotificationFactory, hydratation dynamique derecipient🦺 dynamisation du contenu généré par la méthode
get_serialized_messages🦺 prise en compte de la création du premier
postd'untopicpar le signalcreate_post_notifications🦺 ajustement de la méthode
get_grouped_notificationslors de l'appel àsend_email