Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ajout de nouveaux profils #25

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: ajout de nouveaux profils #25

merged 1 commit into from
Jul 17, 2024

Conversation

hlecuyer
Copy link
Contributor

@hlecuyer hlecuyer commented Jul 9, 2024

No description provided.

@hlecuyer hlecuyer requested a review from vmttn July 9, 2024 14:15
@hlecuyer hlecuyer force-pushed the feat/profils/add-profil-for-fredo-integration branch from 3777f30 to 50d40dd Compare July 9, 2024 15:46
@hlecuyer hlecuyer marked this pull request as ready for review July 10, 2024 07:09
@hlecuyer hlecuyer force-pushed the feat/profils/add-profil-for-fredo-integration branch 3 times, most recently from 0707049 to 413715a Compare July 11, 2024 16:05
vmttn
vmttn requested changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@vmttn vmttn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

est-ce que tu pourrais compléter la section À venir du changelog ?

src/data_inclusion/schema/profils.py Outdated
@@ -32,6 +32,11 @@ class Profil(EnhancedEnum):
"Familles/enfants",
None,
)
ETUDIANTS = (
"etudiants",
"Etudiants",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accent sur majuscule

src/data_inclusion/schema/profils.py Outdated
SENIORS_65 = (
"seniors-65",
"Seniors (+ 65 ans)",
None,
)
SORTANT_DE_DÉTENTION = (
"sortant-de-detention",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

au pluriel

@vmttn vmttn changed the title feat(profil): add profils for fredo integration feat: ajouts de nouveaux profils Jul 17, 2024
@vmttn vmttn changed the title feat: ajouts de nouveaux profils feat: ajout de nouveaux profils Jul 17, 2024
@hlecuyer hlecuyer force-pushed the feat/profils/add-profil-for-fredo-integration branch from 413715a to c47250f Compare July 17, 2024 09:04
@vmttn vmttn force-pushed the feat/profils/add-profil-for-fredo-integration branch from c47250f to a366c10 Compare July 17, 2024 13:01
@vmttn vmttn merged commit 152b2ae into main Jul 17, 2024
3 checks passed
@hlecuyer hlecuyer deleted the feat/profils/add-profil-for-fredo-integration branch August 27, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmttn vmttn vmttn requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hlecuyer @vmttn