Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: minja #11641

Merged
merged 5 commits into from
Feb 5, 2025
Merged

sync: minja #11641

merged 5 commits into from
Feb 5, 2025

Conversation

@ochafik ochafik requested a review from ggerganov February 4, 2025 10:49
@ochafik
Copy link
Collaborator Author

ochafik commented Feb 4, 2025

@bandoti upcoming changes :-)

@bandoti
Copy link
Collaborator

bandoti commented Feb 4, 2025

@ochafik Thanks for the heads up! This gives me a good idea with the llama-cli it has similar behavior from my changes so far. I'll update to use the apply routine directly.

Are you planning on supporting the tool_choice and parallel parameters here as well?

@ochafik ochafik merged commit 9f4cc8f into ggml-org:master Feb 5, 2025
46 checks passed
@ochafik ochafik deleted the sync-minja-4 branch February 5, 2025 01:00
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
orca-zhang pushed a commit to orca-zhang/llama.cpp that referenced this pull request Feb 26, 2025
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples testing Everything test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants