Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move anthropic to dev deps, remove anthropic and groq clients from __init__ #61

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Aug 27, 2024

🚀 This description was created by Ellipsis for commit bd1ae4e

Summary:

Removed AnthropicClient and GroqClient from __init__.py and moved anthropic to dev dependencies in pyproject.toml.

Key points:

  • Removed AnthropicClient and GroqClient imports from graphiti_core/llm_client/__init__.py.
  • Updated __all__ in graphiti_core/llm_client/__init__.py to exclude AnthropicClient and GroqClient.
  • Moved anthropic dependency to [tool.poetry.dev-dependencies] in pyproject.toml.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bd1ae4e in 7 seconds

More details
  • Looked at 37 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. pyproject.toml:37
  • Draft comment:
    The 'anthropic' dependency is listed twice in the dev dependencies. Consider removing the redundant entry to avoid confusion.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The PR moves the 'anthropic' dependency to dev-dependencies, but it is already present in the dev group dependencies. This is redundant and should be addressed.
2. graphiti_core/llm_client/__init__.py:1
  • Draft comment:
    Ensure a copyright notice is present at the top of this file.
  • Reason this comment was not posted:
    Confidence changes required: 80%
    The Python file is missing a copyright notice, which is a requirement.

Workflow ID: wflow_O3MM4CvT40NDG2eb


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Member

@danielchalef danielchalef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paul-paliychuk paul-paliychuk merged commit e821a61 into main Aug 27, 2024
6 checks passed
@paul-paliychuk paul-paliychuk deleted the update-deps branch August 27, 2024 20:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants