depot + cleanup #22
Merged
depot + cleanup #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielchalef
had a problem deploying
to
development
GitHub Actions
Failure
danielchalef
temporarily deployed
to
development
GitHub Actions
Inactive
danielchalef
had a problem deploying
to
development
GitHub Actions
Failure
![ellipsis-dev[bot]](/~https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to eb74de3 in 9 seconds
More details
- Looked at
41lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. Makefile:25
- Draft comment:
Removing--install-types --non-interactivefrom the mypy command might cause issues if type information is missing. Consider keeping it to ensure types are installed automatically. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is speculative and does not point out a definite issue. It suggests a potential problem without confirming its existence. According to the rules, speculative comments should be removed. The comment does not provide actionable feedback or a clear code quality refactor suggestion.
I might be overlooking the importance of the--install-types --non-interactiveoption in certain environments where type information is not already installed. However, the comment does not provide evidence that this is the case here.
Even if the option is important in some contexts, the comment should provide concrete evidence of an issue rather than speculate. Without such evidence, the comment does not meet the criteria for a useful comment.
The comment should be removed as it is speculative and does not provide concrete evidence of an issue. It does not adhere to the rules for useful comments.
Workflow ID: wflow_ZRpX4NFXgQJyVvt4
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates GitHub Actions workflows to use
depot-ubuntu-22.04runner and removes redundantmypyoptions inMakefile.Key points:
.github/workflows/lint.ymlto usedepot-ubuntu-22.04runner..github/workflows/unit_tests.ymlto usedepot-ubuntu-22.04runner.--install-types --non-interactiveoptions frommypycommand inMakefile.Generated with ❤️ by ellipsis.dev