format and linting #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](/~https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d067a92 in 42 seconds
More details
- Looked at
861lines of code in33files - Skipped
1files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. Makefile:30
- Draft comment:
Add a newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:50%
The Makefile is missing a newline at the end of the file, which is a best practice for POSIX compliance.
2. README.md:50
- Draft comment:
Add a newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:50%
The README.md file is missing a newline at the end of the file, which is a best practice for POSIX compliance.
3. SECURITY.md:13
- Draft comment:
Add a newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:50%
The SECURITY.md file is missing a newline at the end of the file, which is a best practice for POSIX compliance.
4. conftest.py:2
- Draft comment:
Ensure imports are grouped by standard library, third-party, and local application imports. - Reason this comment was not posted:
Confidence changes required:20%
The import order in conftest.py should follow the convention of standard library imports first, then third-party imports, and finally local application imports. However, since there are only standard library imports, this is acceptable.
Workflow ID: wflow_EI1FbBaCtfuECfQS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
paul-paliychuk
approved these changes
Aug 22, 2024
danielchalef
force-pushed
the
chore/fix-linting
branch
from
d067a92 to
0b6b03d
Compare
danielchalef
temporarily deployed
to
development
GitHub Actions
Inactive
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0b6b03d in 28 seconds
More details
- Looked at
266lines of code in7files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. core/graphiti.py:1
- Draft comment:
Group import statements according to PEP 8 guidelines: standard library imports, third-party imports, and local application imports should be separated by a blank line. - Reason this comment was not posted:
Confidence changes required:50%
The import statements incore/graphiti.pyare not grouped according to PEP 8 guidelines. Standard library imports, third-party imports, and local application imports should be separated by a blank line.
2. core/search/search.py:1
- Draft comment:
Group import statements according to PEP 8 guidelines: standard library imports, third-party imports, and local application imports should be separated by a blank line. - Reason this comment was not posted:
Confidence changes required:50%
The import statements incore/search/search.pyare not grouped according to PEP 8 guidelines. Standard library imports, third-party imports, and local application imports should be separated by a blank line.
3. core/utils/maintenance/graph_data_operations.py:1
- Draft comment:
Group import statements according to PEP 8 guidelines: standard library imports, third-party imports, and local application imports should be separated by a blank line. - Reason this comment was not posted:
Confidence changes required:50%
The import statements incore/utils/maintenance/graph_data_operations.pyare not grouped according to PEP 8 guidelines. Standard library imports, third-party imports, and local application imports should be separated by a blank line.
Workflow ID: wflow_J5BuKpWFDamvfPbo
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
jackaldenryan
pushed a commit
that referenced
this pull request
Jan 10, 2025
* Makefile and format * fix podcast stuff * refactor: update import statement for transcript_parser in podcast_runner.py * format and linting * chore: Update import statements and remove unused code in maintenance module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a
Makefilefor task automation, reorders imports, fixes paths, and updatespyproject.tomlfor consistent formatting and development dependencies.Key points:
Makefilefor task automation:install,format,lint,test,check.examples/podcastandtests.pyproject.tomlto includeruffandpytestas development dependencies.README.mdandSECURITY.md.Generated with ❤️ by ellipsis.dev