Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit community building concurrency #142

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

danielchalef
Copy link
Member

@danielchalef danielchalef commented Sep 22, 2024

Important

Limits concurrency in build_communities() to 10 using asyncio.Semaphore in community_operations.py.

  • Concurrency Limiting:
    • Introduces MAX_COMMMUNITY_BUILD_CONCURRENCY constant set to 10 in community_operations.py.
    • Adds asyncio.Semaphore to build_communities() to limit concurrency to 10.
    • Wraps build_community() calls in limited_build_community() to enforce concurrency limit.

This description was created by Ellipsis for 4b3a0d9. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 4b3a0d9 in 17 seconds

More details
  • Looked at 32 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. graphiti_core/utils/maintenance/community_operations.py:14
  • Draft comment:
    Typo in constant name: MAX_COMMMUNITY_BUILD_CONCURRENCY should be MAX_COMMUNITY_BUILD_CONCURRENCY.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_MaeAPe3eyvZstYMy


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@danielchalef
Copy link
Member Author

CLA Assistant needs a kick. Will investigate further when I get a moment.

@danielchalef danielchalef merged commit 5d2121e into main Sep 22, 2024
5 of 6 checks passed
@danielchalef danielchalef deleted the chore/community-building-conc branch September 22, 2024 20:38
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants