-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mentions reranker #124
Mentions reranker #124
Conversation
f251180
to
bac9c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 3b18716 in 32 seconds
More details
- Looked at
379
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. graphiti_core/edges.py:313
- Draft comment:
Consider adding a check for emptyedges
list and raisingEdgeNotFoundError
similar to otherget_by_uuids
methods. - Reason this comment was not posted:
Confidence changes required:70%
Theget_by_uuids
method inCommunityEdge
class does not handle the case where no edges are found, unlike the other similar methods.
2. graphiti_core/nodes.py:173
- Draft comment:
The use ofDISTINCT
in theget_by_uuids
method is unnecessary and should be removed to avoid confusion. - Reason this comment was not posted:
Confidence changes required:70%
Theget_by_uuids
method inEpisodicNode
class should not useDISTINCT
as it is not necessary and could lead to confusion.
3. graphiti_core/search/search_utils.py:73
- Draft comment:
Missing comma in the RETURN clause afterc.name_embedding AS name_embedding
. This issue is also present in theget_mentioned_nodes
function. - Reason this comment was not posted:
Confidence changes required:80%
Inget_mentioned_nodes
andget_communities_by_nodes
, there is a missing comma in the RETURN clause.
4. graphiti_core/search/search_utils.py:669
- Draft comment:
The comment about finding the shortest path is misleading. The function counts relationships, not paths. Consider updating the comment for clarity. - Reason this comment was not posted:
Confidence changes required:50%
In theepisode_mentions_reranker
function, the comment about shortest path is misleading as the function is counting relationships, not finding paths.
Workflow ID: wflow_8qAGRi2yBb9a3WmJ
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 3781c7f in 21 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. graphiti_core/edges.py:117
- Draft comment:
Typo in SQL query:INN
should beIN
. This typo is corrected in the PR, but ensure similar issues are not present elsewhere. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment correctly identifies a change made in the diff, which is the correction of a typo in the SQL query. However, the suggestion to ensure similar issues are not present elsewhere is speculative and not actionable based on the current diff. The comment should focus only on the change made, which is the correction of the typo.
The comment does address a change made in the diff, but the additional suggestion to check for similar issues elsewhere is not actionable and speculative.
The main focus should be on the correction made in the diff, which is valid. The speculative part of the comment should be disregarded.
Keep the comment but remove the speculative part about ensuring similar issues are not present elsewhere.
Workflow ID: wflow_gofpqcoxOgL16Qy7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
feat: add episode_mentions reranker and update search configurations
Summary:
Add
episode_mentions
reranker, update search configurations, and enhance edge handling and retrieval methods.Key points:
episode_mentions
reranker toEdgeReranker
andNodeReranker
insearch_config.py
.episode_mentions_reranker()
insearch_utils.py
.edge_search()
andnode_search()
insearch.py
.EDGE_HYBRID_SEARCH_EPISODE_MENTIONS
andNODE_HYBRID_SEARCH_EPISODE_MENTIONS
insearch_config_recipes.py
.get_by_uuids()
method toEpisodicEdge
,EntityEdge
, andCommunityEdge
inedges.py
.dedupe_extracted_edges()
inedge_operations.py
.get_episode_mentions()
ingraphiti.py
.get_by_uuids()
innodes.py
.Generated with ❤️ by ellipsis.dev