Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Syntax error on node crud #119

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix: Syntax error on node crud #119

merged 1 commit into from
Sep 17, 2024

Conversation

paul-paliychuk
Copy link
Collaborator

@paul-paliychuk paul-paliychuk commented Sep 17, 2024

🚀 This description was created by Ellipsis for commit 3c2e09b

fix: add missing commas in SQL queries in nodes.py

Summary:

Fix missing commas in SQL queries in nodes.py and update version to 0.3.2 in pyproject.toml.

Key points:

  • Syntax Fixes:
    • Add missing commas in SQL queries in get_by_uuids() and get_by_uuid() methods in nodes.py.
  • Version Update:
    • Update version in pyproject.toml from 0.3.1 to 0.3.2.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3c2e09b in 3 minutes and 32 seconds

More details
  • Looked at 53 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. graphiti_core/nodes.py:230
  • Draft comment:
    Consider using 'AS' instead of 'As' for consistency in SQL queries. This applies to other instances as well, such as on lines 307 and 329.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR fixes syntax errors by adding missing commas in SQL queries. This is a valid fix, but I noticed a potential issue with the use of 'As' instead of 'AS' in the SQL queries. This could lead to inconsistencies or errors depending on the SQL parser used.

Workflow ID: wflow_PhfJFXCYIp4FFcUl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit ebb1ec2 into main Sep 17, 2024
6 checks passed
@paul-paliychuk paul-paliychuk deleted the fix-crud-syntax branch September 17, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant