chore(sentryapps): better logging and errors for select requester

[Christinarlong]

Ok more like let's differentiate between when we fail due to external requests failing or due to validation errors
Changes:

• Endpoint now throws a ValidationError if we fail to validate the resp or the resp is missing fields
• APIError is only thrown if the request fails
• We still only return 400s so there should be no client side changes
• Update tests to reflect the new exceptions
• Make empty arrays valid response

[iamrajjoshi]

now that we aren't swallowing this exception, do we gracefully handle it?

[Christinarlong]

Good pt, I just added a distinction to check now, if we get ApiError -> we return a message about validation failure and if the request to the webhook goes wrong we return a somewhat generic message and log the error.

/~https://github.com/getsentry/sentry/pull/79377/files#diff-7e1a5ec942c78dda796710a42c8a675441de74e2bdfa4653344b6fd711e73dcfR40-R51

[codecov]

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ps/api/endpoints/installation_external_requests.py	77.77%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #79377       +/-   ##
===========================================
+ Coverage   57.01%   78.35%   +21.33%     
===========================================
  Files        7114     7125       +11     
  Lines      314446   315158      +712     
  Branches    51416    51510       +94     
===========================================
+ Hits       179292   246950    +67658     
+ Misses     130529    61739    -68790     
- Partials     4625     6469     +1844     

[sentaur-athena]

isn't uri enough for debugging here? what added value does url have?

[Christinarlong]

the final url would come in handy in checking who we are contacting, and what the final query stirng is (since for this request we tend to have a bunch of query params).
It is somewhat redundant with the uri though, so I'd probably prefer to keep the url to debug with

[sentaur-athena]

Lol! This TODO seems very old and important. Basically what to do here is to return the error and surface it to the user. Future PRs though.

[sentaur-athena]

Let's merge this :D It would make my life much easier as we have two customers waiting to see why their app is broken.

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ValidationError: Invalid response format for SelectField in id=39357 scope_list=['event:read'] application_id=6569... sentry.api.sentry_app_components.get View Issue
• ‼️ UnboundLocalError: cannot access local variable 'url' where it is not associated with a value sentry.api.sentry_app_components.get View Issue
• ‼️ ValidationError: Invalid response format for SelectField in id=81605 scope_list=['event:read', 'event:write', 'org... sentry.api.sentry_app_components.get View Issue

_{Did you find this useful? React with a 👍 or 👎}