ref(tracing): Deprecate propagate_traces option.
#3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3899 +/- ##
==========================================
+ Coverage 80.15% 80.21% +0.06%
==========================================
Files 139 139
Lines 15391 15394 +3
Branches 2596 2596
==========================================
+ Hits 12337 12349 +12
+ Misses 2208 2202 -6
+ Partials 846 843 -3
|
mgaligniana
force-pushed
the
GH-3106-add-deprecation-warning-to-propagate-traces-option
branch
2 times, most recently
from
5e15320 to
fb72ce0
Compare
mgaligniana
force-pushed
the
GH-3106-add-deprecation-warning-to-propagate-traces-option
branch
from
fb72ce0 to
ecb8dd7
Compare
…o-propagate-traces-option
antonpirker
changed the title
propagate_traces deprecation warningpropagate_traces deprecation warning
antonpirker
changed the title
propagate_traces deprecation warningpropagate_traces option.
…o-propagate-traces-option
github-actions
bot
removed
the
Trigger: tests using secrets
antonpirker
approved these changes
Jan 14, 2025
cmanallen
added a commit
that referenced
this pull request
Feb 13, 2025
)" This reverts commit 8a70b76.
seanh
added a commit
to hypothesis/h-pyramid-sentry
that referenced
this pull request
Feb 14, 2025
As of its [2.21.0 release](/~https://github.com/getsentry/sentry-python/releases/tag/2.21.0) `sentry_sdk`'s Celery integration has begun emitting this deprecation warning: E DeprecationWarning: The `propagate_traces` parameter is deprecated. Please use `trace_propagation_targets` instead. .tox/tests/lib/python3.12/site-packages/sentry_sdk/integrations/celery/__init__.py:73: DeprecationWarning h-pyramid-sentry doesn't actually use the `propagate_traces` parameter. In fact all it's doing is inititalising `sentry_sdk`'s Celery integration with no arguments: from sentry_sdk.integrations.celery import CeleryIntegration init_options["integrations"].append(CeleryIntegration()) /~https://github.com/hypothesis/h-pyramid-sentry/blob/6de9124faa29ca99979bc08318af7c45e0487586/src/h_pyramid_sentry/__init__.py#L54-L56 `sentry_sdk` appears to emit the warning unconditionally whenever anyone uses the Celery integration: class CeleryIntegration(Integration): identifier = "celery" origin = f"auto.queue.{identifier}" def __init__( self, propagate_traces=True, monitor_beat_tasks=False, exclude_beat_tasks=None, ): # type: (bool, bool, Optional[List[str]]) -> None warnings.warn( "The `propagate_traces` parameter is deprecated. Please use `trace_propagation_targets` instead.", DeprecationWarning, stacklevel=2, ) /~https://github.com/getsentry/sentry-python/blob/25ddbcad9642cf38b7a9668e348f80fb9b1c892e/sentry_sdk/integrations/celery/__init__.py#L62-L77 The warning was added by this PR: getsentry/sentry-python#3899. Just ignore the warning, as there's no way for us to fix this.
seanh
added a commit
to hypothesis/h-pyramid-sentry
that referenced
this pull request
Feb 14, 2025
As of its [2.21.0 release](/~https://github.com/getsentry/sentry-python/releases/tag/2.21.0) `sentry_sdk`'s Celery integration has begun emitting this deprecation warning: E DeprecationWarning: The `propagate_traces` parameter is deprecated. Please use `trace_propagation_targets` instead. .tox/tests/lib/python3.12/site-packages/sentry_sdk/integrations/celery/__init__.py:73: DeprecationWarning h-pyramid-sentry doesn't actually use the `propagate_traces` parameter. In fact all it's doing is inititalising `sentry_sdk`'s Celery integration with no arguments: from sentry_sdk.integrations.celery import CeleryIntegration init_options["integrations"].append(CeleryIntegration()) /~https://github.com/hypothesis/h-pyramid-sentry/blob/6de9124faa29ca99979bc08318af7c45e0487586/src/h_pyramid_sentry/__init__.py#L54-L56 `sentry_sdk` appears to emit the warning unconditionally whenever anyone uses the Celery integration: class CeleryIntegration(Integration): identifier = "celery" origin = f"auto.queue.{identifier}" def __init__( self, propagate_traces=True, monitor_beat_tasks=False, exclude_beat_tasks=None, ): # type: (bool, bool, Optional[List[str]]) -> None warnings.warn( "The `propagate_traces` parameter is deprecated. Please use `trace_propagation_targets` instead.", DeprecationWarning, stacklevel=2, ) /~https://github.com/getsentry/sentry-python/blob/25ddbcad9642cf38b7a9668e348f80fb9b1c892e/sentry_sdk/integrations/celery/__init__.py#L62-L77 The warning was added by this PR: getsentry/sentry-python#3899. Just ignore the warning, as there's no way for us to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option is not documented and it is
Trueby default. We should deprecated it and remove in the next major.This option was later superseded by
trace_propagation_targets.Fixes GH-3106