Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(browser): Ensure that performance.measure spans have a positive duration #15415

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

lforst
Copy link
Member

@lforst lforst commented Feb 14, 2025

Third parties may emit measurments with negative durations, causing invalid spans to be emitted, causing relay to drop transactions.

Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.95 KB - -
@sentry/browser - with treeshaking flags 22.73 KB - -
@sentry/browser (incl. Tracing) 35.89 KB +0.02% +5 B 🔺
@sentry/browser (incl. Tracing, Replay) 72.88 KB +0.01% +6 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66.39 KB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 77.13 KB +0.01% +5 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 90.09 KB +0.01% +6 B 🔺
@sentry/browser (incl. Feedback) 40.1 KB - -
@sentry/browser (incl. sendFeedback) 27.58 KB - -
@sentry/browser (incl. FeedbackAsync) 32.38 KB - -
@sentry/react 24.78 KB - -
@sentry/react (incl. Tracing) 37.78 KB +0.02% +5 B 🔺
@sentry/vue 27.14 KB - -
@sentry/vue (incl. Tracing) 37.6 KB +0.02% +5 B 🔺
@sentry/svelte 22.99 KB - -
CDN Bundle 24.17 KB - -
CDN Bundle (incl. Tracing) 35.93 KB +0.02% +5 B 🔺
CDN Bundle (incl. Tracing, Replay) 70.75 KB +0.01% +4 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 75.91 KB +0.01% +7 B 🔺
CDN Bundle - uncompressed 70.64 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.74 KB +0.01% +6 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.95 KB +0.01% +6 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.52 KB +0.01% +6 B 🔺
@sentry/nextjs (client) 38.76 KB +0.02% +5 B 🔺
@sentry/sveltekit (client) 36.32 KB +0.02% +4 B 🔺
@sentry/node 127.61 KB - -
@sentry/node - without tracing 97.9 KB - -
@sentry/aws-serverless 107.34 KB - -

View base workflow run

@lforst lforst marked this pull request as ready for review February 14, 2025 14:07
@lforst lforst requested review from Lms24 and chargome February 14, 2025 14:07
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!

@lforst lforst merged commit f67fa79 into develop Feb 14, 2025
117 checks passed
@lforst lforst deleted the lforst-measure-spans branch February 14, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants