Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browser): Improve setting of propagation scope for navigation spans #15108

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Jan 21, 2025

Extracted this out of #14955

Instead of registering a general hook & filtering there, we can just use the beforeSpanEnd hook that we already have/use to do this instead.

@mydea mydea requested review from lforst and Lms24 January 21, 2025 12:15
@mydea mydea self-assigned this Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.98 KB - -
@sentry/browser - with treeshaking flags 22.87 KB - -
@sentry/browser (incl. Tracing) 35.66 KB -0.07% -25 B 🔽
@sentry/browser (incl. Tracing, Replay) 72.43 KB -0.06% -38 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 66 KB -0.05% -28 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 76.69 KB -0.05% -34 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 88.71 KB -0.04% -28 B 🔽
@sentry/browser (incl. Feedback) 39.19 KB - -
@sentry/browser (incl. sendFeedback) 27.61 KB - -
@sentry/browser (incl. FeedbackAsync) 32.37 KB - -
@sentry/react 25.66 KB - -
@sentry/react (incl. Tracing) 38.43 KB -0.08% -29 B 🔽
@sentry/vue 27.04 KB - -
@sentry/vue (incl. Tracing) 37.41 KB -0.08% -28 B 🔽
@sentry/svelte 23.11 KB - -
CDN Bundle 24.36 KB - -
CDN Bundle (incl. Tracing) 35.97 KB -0.09% -31 B 🔽
CDN Bundle (incl. Tracing, Replay) 70.61 KB -0.05% -35 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 75.75 KB -0.05% -34 B 🔽
CDN Bundle - uncompressed 71.16 KB - -
CDN Bundle (incl. Tracing) - uncompressed 106.72 KB -0.09% -98 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 217.57 KB -0.05% -98 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 230.11 KB -0.05% -98 B 🔽
@sentry/nextjs (client) 38.55 KB -0.08% -30 B 🔽
@sentry/sveltekit (client) 36.18 KB -0.08% -28 B 🔽
@sentry/node 156.17 KB - -
@sentry/node - without tracing 97.32 KB - -
@sentry/aws-serverless 106.74 KB - -

View base workflow run

Copy link

codecov bot commented Jan 21, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
366 1 365 287
View the top 1 failed tests by shortest run time
errors.test.ts errors on frontend and backend are connected by the same trace
Stack Traces | 0.274s run time
errors.test.ts:4:1 errors on frontend and backend are connected by the same trace

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@mydea mydea marked this pull request as ready for review January 21, 2025 12:49
@mydea mydea changed the title ref(browser): Improve when/how propagation scope is kept for navigations ref(browser): Improve setting of propagation scope for navigation spans Jan 21, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring this - much cleaner than before!

@mydea mydea merged commit 580b8b5 into develop Jan 22, 2025
121 checks passed
@mydea mydea deleted the fn/browserTracingEnd branch January 22, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants