Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags/v8): Add Unleash integration #14948

Merged
merged 25 commits into from
Jan 21, 2025
Merged

feat(flags/v8): Add Unleash integration #14948

merged 25 commits into from
Jan 21, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jan 8, 2025

Ref /~https://github.com/getsentry/team-replay/issues/514. Adds an integration for tracking Unleash flag evaluations, by patching the isEnabled method prototype.
Ref https://develop.sentry.dev/sdk/expected-features/#feature-flags

@aliu39 aliu39 marked this pull request as ready for review January 10, 2025 00:05
Copy link

codecov bot commented Jan 15, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
633 2 631 303
View the top 2 failed tests by shortest run time
replay/slowClick/windowOpen/test.ts window.open() is considered for slow click
Stack Traces | 0.805s run time
test.ts:6:11 window.open() is considered for slow click
tracing/browserTracingIntegration/long-tasks-before-navigation/test.ts doesn't capture long task spans starting before a navigation in the navigation transaction
Stack Traces | 30s run time
test.ts:7:11 doesn't capture long task spans starting before a navigation in the navigation transaction

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@aliu39 aliu39 requested a review from billyvg January 15, 2025 18:54
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would you want to point that PR at develop and backport it to v8 maybe?

@aliu39 aliu39 changed the title feat(flags): add Unleash integration feat(flags): add Unleash integration (v8) Jan 16, 2025
@aliu39
Copy link
Member Author

aliu39 commented Jan 16, 2025

Looks good, would you want to point that PR at develop and backport it to v8 maybe?

@chargome Sounds good! I opened #15036

@lforst lforst changed the title feat(flags): add Unleash integration (v8) feat(flags/v8): Add Unleash integration Jan 16, 2025
aliu39 added a commit that referenced this pull request Jan 21, 2025
@aliu39 aliu39 merged commit b0dc860 into v8 Jan 21, 2025
124 checks passed
@aliu39 aliu39 deleted the aliu/unleash branch January 21, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants